Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add test for unpacking interface on validator request #9391

Merged
merged 8 commits into from
May 26, 2021
Merged

test: add test for unpacking interface on validator request #9391

merged 8 commits into from
May 26, 2021

Conversation

technicallyty
Copy link
Contributor

Description

  • Adds test to show unpacking interface on validator after Validator gRPC request
  • Adds line to encoding documentation for the Validator being fully encoded as Any

closes: #8045

Before we can merge this PR, please make sure that all the following items have been
checked off. If any of the checklist items are not applicable, please leave them but
write a little note why.

  • Targeted PR against correct branch (see CONTRIBUTING.md)
  • Linked to Github issue with discussion and accepted design OR link to spec that describes this work.
  • Code follows the module structure standards.
  • Wrote unit and integration tests
  • Updated relevant documentation (docs/) or specification (x/<module>/spec/)
  • Added relevant godoc comments.
  • Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
  • Re-reviewed Files changed in the Github PR explorer
  • Review Codecov Report in the comment section below once CI passes

@github-actions github-actions bot added the T:Docs Changes and features related to documentation. label May 25, 2021
amaury1093
amaury1093 approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@amaury1093 amaury1093 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

docs/core/encoding.md Outdated Show resolved Hide resolved
server/grpc/server_test.go Outdated Show resolved Hide resolved
ryanchristo
ryanchristo approved these changes May 26, 2021
View reviewed changes
Copy link
Contributor

@ryanchristo ryanchristo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ryanchristo
ryanchristo reviewed May 26, 2021
View reviewed changes
docs/core/encoding.md Outdated Show resolved Hide resolved
@technicallyty @ryanchristo
Update docs/core/encoding.md
fa919fa 
Co-authored-by: Ryan Christoffersen <12519942+ryanchristo@users.noreply.github.com>
@technicallyty technicallyty added the A:automerge Automatically merge PR once all prerequisites pass. label May 26, 2021
@mergify mergify bot merged commit a93ed22 into master May 26, 2021
@mergify mergify bot deleted the ty/8045-unpack-test branch May 26, 2021 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryanchristo ryanchristo ryanchristo approved these changes

@tac0turtle tac0turtle tac0turtle approved these changes

@amaury1093 amaury1093 amaury1093 approved these changes

@aaronc aaronc Awaiting requested review from aaronc

@alexanderbez alexanderbez Awaiting requested review from alexanderbez

@robert-zaremba robert-zaremba Awaiting requested review from robert-zaremba

Assignees
No one assigned
Labels
A:automerge Automatically merge PR once all prerequisites pass. T:Docs Changes and features related to documentation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Can not get Validator's Conspubkey
4 participants
@technicallyty @amaury1093 @ryanchristo @tac0turtle